Commit 20690cd5 authored by Dong Chenchen's avatar Dong Chenchen Committed by Jonathan Cameron
Browse files

iio: accel: bma400: Fix memory leak in bma400_get_steps_reg() 



When regmap_bulk_read() fails, it does not free steps_raw,
which will cause a memory leak issue, this patch fixes it.

Fixes: d221de60 ("iio: accel: bma400: Add separate channel for step counter")
Signed-off-by: default avatarDong Chenchen <dongchenchen2@huawei.com>
Reviewed-by: default avatarJagath Jog J <jagathjog1996@gmail.com>
Link: https://lore.kernel.org/r/20221110010726.235601-1-dongchenchen2@huawei.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 6ac12303

drivers/iio/accel/bma400_core.c

+3 −1
Original line number Diff line number Diff line
@@ -805,8 +805,10 @@ static int bma400_get_steps_reg(struct bma400_data *data, int *val) 


	ret = regmap_bulk_read(data->regmap, BMA400_STEP_CNT0_REG,

			       steps_raw, BMA400_STEP_RAW_LEN);

	if (ret)

	if (ret) {

		kfree(steps_raw);

		return ret;

	}

	*val = get_unaligned_le24(steps_raw);

	kfree(steps_raw);

	return IIO_VAL_INT;