Commit 20534dbc authored by Shashank Sharma's avatar Shashank Sharma Committed by Alex Deucher
Browse files

drm/amdgpu: fix return value check in kfd 



This patch fixes a return value check in kfd doorbell handling.
This function should return 0(error) only when the ida_simple_get
returns < 0(error), return > 0 is a success case.

Cc: Felix Kuehling <Felix.Kuehling@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Fixes: 16f00131 ("drm/amdkfd: Allocate doorbells only when needed")
Acked-by: default avatarChristian Koenig <chriatian.koenig@amd.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarShashank Sharma <shashank.sharma@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1717cc5f

drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c

+1 −1
Original line number Diff line number Diff line
@@ -280,7 +280,7 @@ phys_addr_t kfd_get_process_doorbells(struct kfd_process_device *pdd) 
	if (!pdd->doorbell_index) {

		int r = kfd_alloc_process_doorbells(pdd->dev,

						    &pdd->doorbell_index);

		if (r)

		if (r < 0)

			return 0;

	}