Commit 202865cc authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Dave Chinner
Browse files

xfs: warn about LARP once per mount 



Since LARP is an experimental debug-only feature, we should try to warn
about it being in use once per mount, not once per reboot.

Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent df5660cf

fs/xfs/xfs_log.c

+2 −2
Original line number Diff line number Diff line
@@ -3910,8 +3910,8 @@ xfs_attr_use_log_assist( 
	if (error)

		goto drop_incompat;



	xfs_warn_once(mp,

"EXPERIMENTAL logged extended attributes feature added. Use at your own risk!");

	xfs_warn_mount(mp, XFS_OPSTATE_WARNED_LARP,

 "EXPERIMENTAL logged extended attributes feature in use. Use at your own risk!");



	return 0;

drop_incompat:

fs/xfs/xfs_mount.h

+4 −1
Original line number Diff line number Diff line
@@ -395,6 +395,8 @@ __XFS_HAS_FEAT(nouuid, NOUUID) 
#define XFS_OPSTATE_WARNED_SCRUB	7

/* Kernel has logged a warning about shrink being used on this fs. */

#define XFS_OPSTATE_WARNED_SHRINK	8

/* Kernel has logged a warning about logged xattr updates being used. */

#define XFS_OPSTATE_WARNED_LARP		9



#define __XFS_IS_OPSTATE(name, NAME) \

static inline bool xfs_is_ ## name (struct xfs_mount *mp) \
@@ -433,7 +435,8 @@ xfs_should_warn(struct xfs_mount *mp, long nr) 
	{ (1UL << XFS_OPSTATE_INODEGC_ENABLED),		"inodegc" }, \

	{ (1UL << XFS_OPSTATE_BLOCKGC_ENABLED),		"blockgc" }, \

	{ (1UL << XFS_OPSTATE_WARNED_SCRUB),		"wscrub" }, \

	{ (1UL << XFS_OPSTATE_WARNED_SHRINK),		"wshrink" }

	{ (1UL << XFS_OPSTATE_WARNED_SHRINK),		"wshrink" }, \

	{ (1UL << XFS_OPSTATE_WARNED_LARP),		"wlarp" }



/*

 * Max and min values for mount-option defined I/O