Commit 2002eb6d authored Aug 03, 2023 by Jani Nikula Committed by Rodrigo Vivi Aug 14, 2023

drm/i915/sdvo: fix panel_type initialization



Commit 3f9ffce5 ("drm/i915: Do panel VBT init early if the VBT
declares an explicit panel type") started using -1 as the value for
unset panel_type. It gets initialized in intel_panel_init_alloc(), but
the SDVO code never calls it.

Call intel_panel_init_alloc() to initialize the panel, including the
panel_type.

Reported-by: Tomi Leppänen <tomi@tomin.site>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8896


Fixes: 3f9ffce5 ("drm/i915: Do panel VBT init early if the VBT declares an explicit panel type")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v6.1+
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Tested-by: Tomi Leppänen <tomi@tomin.site>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803122706.838721-1-jani.nikula@intel.com


(cherry picked from commit 26e60294)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

parent 5598c9bf

drivers/gpu/drm/i915/display/intel_sdvo.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2752,7 +2752,7 @@ static struct intel_sdvo_connector *intel_sdvo_connector_alloc(void)
		__drm_atomic_helper_connector_reset(&sdvo_connector->base.base,
		&conn_state->base.base);

		INIT_LIST_HEAD(&sdvo_connector->base.panel.fixed_modes);
		intel_panel_init_alloc(&sdvo_connector->base);

		return sdvo_connector;
		}