Commit 1ffa7bfa authored by Baoyou Xie's avatar Baoyou Xie Committed by Jens Axboe
Browse files

drbd: mark symbols static where possible 



We get a few warnings when building kernel with W=1:
drbd/drbd_receiver.c:1224:6: warning: no previous prototype for 'one_flush_endio' [-Wmissing-prototypes]
drbd/drbd_req.c:1450:6: warning: no previous prototype for 'send_and_submit_pending' [-Wmissing-prototypes]
drbd/drbd_main.c:924:6: warning: no previous prototype for 'assign_p_sizes_qlim' [-Wmissing-prototypes]
....

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.

Signed-off-by: default avatarBaoyou Xie <baoyou.xie@linaro.org>
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e1fbc4ca

drivers/block/drbd/drbd_main.c

+3 −1
Original line number Diff line number Diff line
@@ -923,7 +923,9 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device) 
}



/* communicated if (agreed_features & DRBD_FF_WSAME) */

void assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p, struct request_queue *q)

static void

assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p,

					struct request_queue *q)

{

	if (q) {

		p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q));

drivers/block/drbd/drbd_receiver.c

+1 −1
Original line number Diff line number Diff line
@@ -1261,7 +1261,7 @@ struct one_flush_context { 
	struct issue_flush_context *ctx;

};



void one_flush_endio(struct bio *bio)

static void one_flush_endio(struct bio *bio)

{

	struct one_flush_context *octx = bio->bi_private;

	struct drbd_device *device = octx->device;

drivers/block/drbd/drbd_worker.c

+2 −1
Original line number Diff line number Diff line
@@ -203,7 +203,8 @@ void drbd_peer_request_endio(struct bio *bio) 
	}

}



void drbd_panic_after_delayed_completion_of_aborted_request(struct drbd_device *device)

static void

drbd_panic_after_delayed_completion_of_aborted_request(struct drbd_device *device)

{

	panic("drbd%u %s/%u potential random memory corruption caused by delayed completion of aborted local request\n",

		device->minor, device->resource->name, device->vnr);