Commit 1f6c45ac authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

atomisp: don't let it go past pipes array 



In practice, IA_CSS_PIPE_ID_NUM should never be used when
calling atomisp_q_video_buffers_to_css(), as the driver should
discover the right pipe before calling it.

Yet, if some pipe parsing issue happens, it could end using
it.

So, add a WARN_ON() to prevent such case.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 1cb3ff13

drivers/staging/media/atomisp/pci/atomisp_fops.c

+3 −0
Original line number Diff line number Diff line
@@ -221,6 +221,9 @@ int atomisp_q_video_buffers_to_css(struct atomisp_sub_device *asd, 
	unsigned long irqflags;

	int err = 0;



	if (WARN_ON(css_pipe_id >= IA_CSS_PIPE_ID_NUM))

		return -EINVAL;



	while (pipe->buffers_in_css < ATOMISP_CSS_Q_DEPTH) {

		struct videobuf_buffer *vb;