Commit 1f464cb4 authored by Liao Chang's avatar Liao Chang Committed by Rafael J. Wysocki
Browse files

cpufreq: Avoid printing kernel addresses in cpufreq_resume() 

The pointer value of policy and driver structure are currently printed
in the error messages of cpufreq_resume(), this is not recommended and
helpful.

In order to be consistent with the error message in cpufreq_suspend()
and easier to understand, print the name of driver strcture and the
manage CPU of policy structure individually in the error messages of
cpufreq_resume().

Link: https://lore.kernel.org/all/b7be717c-41d8-bbbf-3e97-3799948ab757@huawei.com


Signed-off-by: default avatarLiao Chang <liaochang1@huawei.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent ccc5e981

drivers/cpufreq/cpufreq.c

+4 −4
Original line number Diff line number Diff line
@@ -1943,16 +1943,16 @@ void cpufreq_resume(void) 


	for_each_active_policy(policy) {

		if (cpufreq_driver->resume && cpufreq_driver->resume(policy)) {

			pr_err("%s: Failed to resume driver: %p\n", __func__,

				policy);

			pr_err("%s: Failed to resume driver: %s\n", __func__,

				cpufreq_driver->name);

		} else if (has_target()) {

			down_write(&policy->rwsem);

			ret = cpufreq_start_governor(policy);

			up_write(&policy->rwsem);



			if (ret)

				pr_err("%s: Failed to start governor for policy: %p\n",

				       __func__, policy);

				pr_err("%s: Failed to start governor for CPU%u's policy\n",

				       __func__, policy->cpu);

		}

	}

}