Unverified Commit 1f3c3632 authored Feb 13, 2020 by Tiezhu Yang Committed by Mark Brown Feb 13, 2020

spi: spidev_test: Check input_tx and input_file first after parse options



It is better to check input_tx and input_file first after parse options.
Otherwise, it will do some useless operations when both -p and --input
are selected.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1581567368-8055-2-git-send-email-yangtiezhu@loongson.cn


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 020bd6c4

tools/spi/spidev_test.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -404,6 +404,9 @@ int main(int argc, char *argv[])

		parse_opts(argc, argv);

		if (input_tx && input_file)
		pabort("only one of -p and --input may be selected");

		fd = open(device, O_RDWR);
		if (fd < 0)
		pabort("can't open device");
		@@ -445,9 +448,6 @@ int main(int argc, char *argv[])
		printf("bits per word: %d\n", bits);
		printf("max speed: %d Hz (%d KHz)\n", speed, speed/1000);

		if (input_tx && input_file)
		pabort("only one of -p and --input may be selected");

		if (input_tx)
		transfer_escaped_string(fd, input_tx);
		else if (input_file)