Commit 1f1c9213 authored by Danielle Ratson's avatar Danielle Ratson Committed by David S. Miller
Browse files

selftests: mlxsw: Remove a redundant if statement in tc_flower_scale test 



Currently, the error return code of the failure condition is lost after
using an if statement, so the test doesn't fail when it should.

Remove the if statement that separates the condition and the error code
check, so the test won't always pass.

Fixes: abfce9e0 ("selftests: mlxsw: Reduce running time using offload indication")
Reported-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDanielle Ratson <danieller@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b6fc2f21

tools/testing/selftests/drivers/net/mlxsw/tc_flower_scale.sh

+1 −5
Original line number Diff line number Diff line
@@ -98,11 +98,7 @@ __tc_flower_test() 
			jq -r '[ .[] | select(.kind == "flower") |

			.options | .in_hw ]' | jq .[] | wc -l)

	[[ $((offload_count - 1)) -eq $count ]]

	if [[ $should_fail -eq 0 ]]; then

		check_err $? "Offload mismatch"

	else

		check_err_fail $should_fail $? "Offload more than expacted"

	fi

	check_err_fail $should_fail $? "Attempt to offload $count rules (actual result $((offload_count - 1)))"

}



tc_flower_test()