Commit 1f0cb8bc authored by Sargun Dhillon's avatar Sargun Dhillon Committed by Miklos Szeredi
Browse files

ovl: plumb through flush method 



Filesystems can implement their own flush method that release
resources, or manipulate caches. Currently if one of these
filesystems is used with overlayfs, the flush method is not called.

[Amir: fix fd leak in ovl_flush()]

Signed-off-by: default avatarSargun Dhillon <sargun@sargun.me>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent e49d033b

fs/overlayfs/file.c

+21 −0
Original line number Diff line number Diff line
@@ -686,6 +686,26 @@ static loff_t ovl_remap_file_range(struct file *file_in, loff_t pos_in, 
			    remap_flags, op);

}



static int ovl_flush(struct file *file, fl_owner_t id)

{

	struct fd real;

	const struct cred *old_cred;

	int err;



	err = ovl_real_fdget(file, &real);

	if (err)

		return err;



	if (real.file->f_op->flush) {

		old_cred = ovl_override_creds(file_inode(file)->i_sb);

		err = real.file->f_op->flush(real.file, id);

		revert_creds(old_cred);

	}

	fdput(real);



	return err;

}



const struct file_operations ovl_file_operations = {

	.open		= ovl_open,

	.release	= ovl_release,
@@ -697,6 +717,7 @@ const struct file_operations ovl_file_operations = { 
	.fallocate	= ovl_fallocate,

	.fadvise	= ovl_fadvise,

	.unlocked_ioctl	= ovl_ioctl,

	.flush		= ovl_flush,

#ifdef CONFIG_COMPAT

	.compat_ioctl	= ovl_compat_ioctl,

#endif