Commit 1edb5cbf authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

Revert "net-loopback: set lo dev initial state to UP"



In commit c9dca822 ("net-loopback: set lo dev initial state to UP"),
linux started automatically bringing up the loopback device of a newly
created namespace. However, an existing user script might reasonably have
the following stanza when creating a new namespace -- and in fact at least
tools/testing/selftests/net/fib_nexthops.sh in Linux's very own testsuite
does:

 # set -e
 # ip netns add foo
 # ip -netns foo addr add 127.0.0.1/8 dev lo
 # ip -netns foo link set lo up
 # set +e

This will now fail, because the kernel reasonably rejects "ip addr add" of
a duplicate address. The described change of behavior therefore constitutes
a breakage. Revert it.

Fixes: c9dca822 ("net-loopback: set lo dev initial state to UP")
Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4217a64e
Loading
Loading
Loading
Loading
+0 −6
Original line number Diff line number Diff line
@@ -219,12 +219,6 @@ static __net_init int loopback_net_init(struct net *net)

	BUG_ON(dev->ifindex != LOOPBACK_IFINDEX);
	net->loopback_dev = dev;

	/* bring loopback device UP */
	rtnl_lock();
	dev_open(dev, NULL);
	rtnl_unlock();

	return 0;

out_free_netdev: