Commit 1ed4dba2 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: s5m: signal the core when alarm are not available 



Clear the RTC_FEATURE_ALARM bit to signal to the core when alarms are not
available to ensure the alarm callbacks are never called and userspace is
aware alarms are not supported.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210804104133.5158-2-alexandre.belloni@bootlin.com
parent dae68c6b

drivers/rtc/rtc-s5m.c

+11 −16
Original line number Diff line number Diff line
@@ -794,15 +794,9 @@ static int s5m_rtc_probe(struct platform_device *pdev) 


	info->rtc_dev->ops = &s5m_rtc_ops;



	err = devm_rtc_register_device(info->rtc_dev);

	if (err)

		return err;



	if (!info->irq) {

		dev_info(&pdev->dev, "Alarm IRQ not available\n");

		return 0;

	}



		clear_bit(RTC_FEATURE_ALARM, info->rtc_dev->features);

	} else {

		ret = devm_request_threaded_irq(&pdev->dev, info->irq, NULL,

						s5m_rtc_alarm_irq, 0, "rtc-alarm0",

						info);
@@ -811,8 +805,9 @@ static int s5m_rtc_probe(struct platform_device *pdev) 
				info->irq, ret);

			return ret;

		}

	}



	return 0;

	return devm_rtc_register_device(info->rtc_dev);

}



#ifdef CONFIG_PM_SLEEP