Commit 1ec3d02f authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller
Browse files

qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()' 



This ++ is confusing. It looks duplicated with the one already performed in
'skb_fill_page_desc()'.

In fact, it is harmless. 'nr_frags' is written twice with the same value.
Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1'
in 'skb_fill_page_desc()'.

So axe this post-increment to avoid confusion.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarManish Chopra <manishc@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c438a801

drivers/net/ethernet/qlogic/qede/qede_fp.c

+1 −1
Original line number Diff line number Diff line
@@ -1209,7 +1209,7 @@ static int qede_rx_build_jumbo(struct qede_dev *edev, 
		dma_unmap_page(rxq->dev, bd->mapping,

			       PAGE_SIZE, DMA_FROM_DEVICE);



		skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,

		skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,

				   bd->data, rxq->rx_headroom, cur_size);



		skb->truesize += PAGE_SIZE;