Unverified Commit 1ec0c91f authored Jun 14, 2022 by Colin Ian King Committed by Mark Brown Jun 16, 2022

ASoC: Intel: Skylake: remove redundant re-assignments to pointer array



There are two occurrences where the pointer array is being assigned a value
that is never read, the pointer gets updated in the next iteration of a
loop. These assignments are redundant and can be removed.

Cleans up clang scan-build warnings:
sound/soc/intel/skylake/skl-topology.c:2953:3: warning: Value stored to
'array' is never read [deadcode.DeadStores]
sound/soc/intel/skylake/skl-topology.c:3602:3: warning: Value stored to
'array' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20220614183809.163531-1-colin.i.king@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 7acf970a

sound/soc/intel/skylake/skl-topology.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -2950,9 +2950,6 @@ static int skl_tplg_get_pvt_data(struct snd_soc_tplg_dapm_widget *tplg_w,
		block_size = ret;
		off += array->size;

		array = (struct snd_soc_tplg_vendor_array *)
		(tplg_w->priv.data + off);

		data = (tplg_w->priv.data + off);

		if (block_type == SKL_TYPE_TUPLE) {
		@@ -3599,9 +3596,6 @@ static int skl_tplg_get_manifest_data(struct snd_soc_tplg_manifest *manifest,
		block_size = ret;
		off += array->size;

		array = (struct snd_soc_tplg_vendor_array *)
		(manifest->priv.data + off);

		data = (manifest->priv.data + off);

		if (block_type == SKL_TYPE_TUPLE) {