Commit 1ebafd5f authored by Andrew Davis's avatar Andrew Davis Committed by Wolfram Sang
Browse files

i2c: davinci: Use struct name not type with devm_kzalloc() 



This reduces chance of error if the type of "dev" changes. While here
remove extra error print out, this is not usually done for memory
allocation failures.

Signed-off-by: default avatarAndrew Davis <afd@ti.com>
Reviewed-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent c3cc5c59

drivers/i2c/busses/i2c-davinci.c

+2 −5
Original line number Diff line number Diff line
@@ -767,12 +767,9 @@ static int davinci_i2c_probe(struct platform_device *pdev) 
	if (irq < 0)

		return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");



	dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),

			GFP_KERNEL);

	if (!dev) {

		dev_err(&pdev->dev, "Memory allocation failed\n");

	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);

	if (!dev)

		return -ENOMEM;

	}



	init_completion(&dev->cmd_complete);