Commit 1eb91125 authored by Pali Rohár's avatar Pali Rohár Committed by Ulf Hansson
Browse files

mmc: sdio: Fix Cypress SDIO IDs macros in common include file 



All macro names for SDIO device IDs are prefixed by vendor name to which
device ID belongs. So for consistency add Broadcom string vendor prefix to
all Cypress macro names as they belong to SDIO Broadcom vendor ID.

Change also Cypress 43012 value from decimal do hexadecimal notation to be
consistent with all other values.

Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20200522144412.19712-11-pali@kernel.org


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 8baa6d1b

drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

+3 −3
Original line number Diff line number Diff line
@@ -970,9 +970,9 @@ static const struct sdio_device_id brcmf_sdmmc_ids[] = { 
	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4354),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4356),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4359),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_4373),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_43012),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_89359),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_43012),

	BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_CYPRESS_89359),

	{ /* end: all zeroes */ }

};

MODULE_DEVICE_TABLE(sdio, brcmf_sdmmc_ids);

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

+2 −2
Original line number Diff line number Diff line
@@ -4187,7 +4187,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err, 
				   bus->hostintmask, NULL);



		switch (sdiod->func1->device) {

		case SDIO_DEVICE_ID_CYPRESS_4373:

		case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:

			brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n",

				  CY_4373_F2_WATERMARK);

			brcmf_sdiod_writeb(sdiod, SBSDIO_WATERMARK,
@@ -4201,7 +4201,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err, 
					   CY_4373_F2_WATERMARK |

					   SBSDIO_MESBUSYCTRL_ENAB, &err);

			break;

		case SDIO_DEVICE_ID_CYPRESS_43012:

		case SDIO_DEVICE_ID_BROADCOM_CYPRESS_43012:

			brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes\n",

				  CY_43012_F2_WATERMARK);

			brcmf_sdiod_writeb(sdiod, SBSDIO_WATERMARK,

include/linux/mmc/sdio_ids.h

+3 −3
Original line number Diff line number Diff line
@@ -58,9 +58,9 @@ 
#define SDIO_DEVICE_ID_BROADCOM_4354		0x4354

#define SDIO_DEVICE_ID_BROADCOM_4356		0x4356

#define SDIO_DEVICE_ID_BROADCOM_4359		0x4359

#define SDIO_DEVICE_ID_CYPRESS_4373		0x4373

#define SDIO_DEVICE_ID_CYPRESS_43012		43012

#define SDIO_DEVICE_ID_CYPRESS_89359		0x4355

#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373	0x4373

#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_43012	0xa804

#define SDIO_DEVICE_ID_BROADCOM_CYPRESS_89359	0x4355



#define SDIO_VENDOR_ID_INTEL			0x0089

#define SDIO_DEVICE_ID_INTEL_IWMC3200WIMAX	0x1402