Commit 1ea3615b authored Oct 17, 2021 by Jonathan Cameron

iio: accel: sca3000: Use sign_extend32() instead of opencoding sign extension.



Whilst nice to get rid of this non obvious code, this also clears a
static checker warning:

drivers/iio/accel/sca3000.c:734 sca3000_read_raw()
warn: no-op. '((*val) << 19) >> 19'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211017160303.72441-1-jic23@kernel.org

parent dd4efd05

drivers/iio/accel/sca3000.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -731,8 +731,7 @@ static int sca3000_read_raw(struct iio_dev *indio_dev,
		return ret;
		}
		val = (be16_to_cpup((__be16 )st->rx) >> 3) & 0x1FFF;
		val = ((val) << (sizeof(val) 8 - 13)) >>
		(sizeof(val) 8 - 13);
		val = sign_extend32(val, 12);
		} else {
		/* get the temperature when available */
		ret = sca3000_read_data_short(st,