Commit 1e81dcc1 authored by Vinicius Costa Gomes's avatar Vinicius Costa Gomes Committed by Tony Nguyen
Browse files

igc: Do not enable crosstimestamping for i225-V models 

It was reported that when PCIe PTM is enabled, some lockups could
be observed with some integrated i225-V models.

While the issue is investigated, we can disable crosstimestamp for
those models and see no loss of functionality, because those models
don't have any support for time synchronization.

Fixes: a90ec848 ("igc: Add support for PTP getcrosststamp()")
Link: https://lore.kernel.org/all/924175a188159f4e03bd69908a91e606b574139b.camel@gmx.de/


Reported-by: default avatarStefan Dietrich <roots@gmx.de>
Signed-off-by: default avatarVinicius Costa Gomes <vinicius.gomes@intel.com>
Tested-by: default avatarNechama Kraus <nechamax.kraus@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 16fa29ae

drivers/net/ethernet/intel/igc/igc_ptp.c

+14 −1
Original line number Diff line number Diff line
@@ -768,7 +768,20 @@ int igc_ptp_get_ts_config(struct net_device *netdev, struct ifreq *ifr) 
 */

static bool igc_is_crosststamp_supported(struct igc_adapter *adapter)

{

	return IS_ENABLED(CONFIG_X86_TSC) ? pcie_ptm_enabled(adapter->pdev) : false;

	if (!IS_ENABLED(CONFIG_X86_TSC))

		return false;



	/* FIXME: it was noticed that enabling support for PCIe PTM in

	 * some i225-V models could cause lockups when bringing the

	 * interface up/down. There should be no downsides to

	 * disabling crosstimestamping support for i225-V, as it

	 * doesn't have any PTP support. That way we gain some time

	 * while root causing the issue.

	 */

	if (adapter->pdev->device == IGC_DEV_ID_I225_V)

		return false;



	return pcie_ptm_enabled(adapter->pdev);

}



static struct system_counterval_t igc_device_tstamp_to_system(u64 tstamp)