Commit 1e661f81 authored by Cédric Le Goater's avatar Cédric Le Goater Committed by Michael Ellerman
Browse files

powerpc/xics: Drop unmask of MSIs at startup 



That was a workaround in the XICS domain because of the lack of MSI
domain. This is now handled.

Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210701132750.1475580-24-clg@kaod.org
parent 679e30b9

arch/powerpc/sysdev/xics/ics-opal.c

+0 −11
Original line number Diff line number Diff line
@@ -62,17 +62,6 @@ static void ics_opal_unmask_irq(struct irq_data *d) 


static unsigned int ics_opal_startup(struct irq_data *d)

{

#ifdef CONFIG_PCI_MSI

	/*

	 * The generic MSI code returns with the interrupt disabled on the

	 * card, using the MSI mask bits. Firmware doesn't appear to unmask

	 * at that level, so we do it here by hand.

	 */

	if (irq_data_get_msi_desc(d))

		pci_msi_unmask_irq(d);

#endif



	/* unmask it */

	ics_opal_unmask_irq(d);

	return 0;

}

arch/powerpc/sysdev/xics/ics-rtas.c

+0 −9
Original line number Diff line number Diff line
@@ -57,15 +57,6 @@ static void ics_rtas_unmask_irq(struct irq_data *d) 


static unsigned int ics_rtas_startup(struct irq_data *d)

{

#ifdef CONFIG_PCI_MSI

	/*

	 * The generic MSI code returns with the interrupt disabled on the

	 * card, using the MSI mask bits. Firmware doesn't appear to unmask

	 * at that level, so we do it here by hand.

	 */

	if (irq_data_get_msi_desc(d))

		pci_msi_unmask_irq(d);

#endif

	/* unmask it */

	ics_rtas_unmask_irq(d);

	return 0;