Commit 1e532d2b authored by Steffen Klassert's avatar Steffen Klassert
Browse files

af_key: Fix memory leak in key_notify_policy. 



We leak the allocated out_skb in case
pfkey_xfrm_policy2msg() fails. Fix this
by freeing it on error.

Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent 374d1b5a

net/key/af_key.c

+3 −1
Original line number Diff line number Diff line
@@ -2202,8 +2202,10 @@ static int key_notify_policy(struct xfrm_policy *xp, int dir, const struct km_ev 
		return PTR_ERR(out_skb);



	err = pfkey_xfrm_policy2msg(out_skb, xp, dir);

	if (err < 0)

	if (err < 0) {

		kfree_skb(out_skb);

		return err;

	}



	out_hdr = (struct sadb_msg *) out_skb->data;

	out_hdr->sadb_msg_version = PF_KEY_V2;