Commit 1e3cc212 authored by Yu Kuai's avatar Yu Kuai Committed by Jens Axboe
Browse files

block, bfq: remove useless checking in bfq_put_queue() 



'bfqq->bfqd' is ensured to set in bfq_init_queue(), and it will never
change afterwards.

Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220816015631.1323948-3-yukuai1@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent c2090eab

block/bfq-iosched.c

+2 −4
Original line number Diff line number Diff line
@@ -5255,9 +5255,7 @@ void bfq_put_queue(struct bfq_queue *bfqq) 
	struct hlist_node *n;

	struct bfq_group *bfqg = bfqq_group(bfqq);



	if (bfqq->bfqd)

		bfq_log_bfqq(bfqq->bfqd, bfqq, "put_queue: %p %d",

			     bfqq, bfqq->ref);

	bfq_log_bfqq(bfqq->bfqd, bfqq, "put_queue: %p %d", bfqq, bfqq->ref);



	bfqq->ref--;

	if (bfqq->ref)
@@ -5321,7 +5319,7 @@ void bfq_put_queue(struct bfq_queue *bfqq) 
		hlist_del_init(&item->woken_list_node);

	}



	if (bfqq->bfqd && bfqq->bfqd->last_completed_rq_bfqq == bfqq)

	if (bfqq->bfqd->last_completed_rq_bfqq == bfqq)

		bfqq->bfqd->last_completed_rq_bfqq = NULL;



	kmem_cache_free(bfq_pool, bfqq);