Commit 1e3c3a79 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Guenter Roeck
Browse files

hwmon: (vt8231) Do PCI error checks on own line 



Instead of if conditions with line splits, use the usual error handling
pattern with a separate variable to improve readability.

No functional changes intended.

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230824132832.78705-7-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 70332ec7

drivers/hwmon/vt8231.c

+6 −5
Original line number Diff line number Diff line
@@ -971,13 +971,15 @@ static int vt8231_pci_probe(struct pci_dev *dev, 
				const struct pci_device_id *id)

{

	u16 address, val;

	int ret;



	if (force_addr) {

		address = force_addr & 0xff00;

		dev_warn(&dev->dev, "Forcing ISA address 0x%x\n",

			 address);



		if (PCIBIOS_SUCCESSFUL !=

		    pci_write_config_word(dev, VT8231_BASE_REG, address | 1))

		ret = pci_write_config_word(dev, VT8231_BASE_REG, address | 1);

		if (ret != PCIBIOS_SUCCESSFUL)

			return -ENODEV;

	}
@@ -997,9 +999,8 @@ static int vt8231_pci_probe(struct pci_dev *dev, 


	if (!(val & 0x0001)) {

		dev_warn(&dev->dev, "enabling sensors\n");

		if (PCIBIOS_SUCCESSFUL !=

			pci_write_config_word(dev, VT8231_ENABLE_REG,

							val | 0x0001))

		ret = pci_write_config_word(dev, VT8231_ENABLE_REG, val | 0x1);

		if (ret != PCIBIOS_SUCCESSFUL)

			return -ENODEV;

	}