Commit 1e16f382 authored Jan 29, 2021 by Nikolay Aleksandrov Committed by Jakub Kicinski Jan 29, 2021

net: bridge: add warning comments to avoid extending sysfs



We're moving to netlink-only options, so add comments in the bridge's
sysfs files to warn against adding any new sysfs entries.

Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 7d0888d5

net/bridge/br_sysfs_br.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -19,6 +19,10 @@

		#include "br_private.h"

		/* IMPORTANT: new bridge options must be added with netlink support only
		* please do not add new sysfs entries
		*/

		#define to_bridge(cd) ((struct net_bridge *)netdev_priv(to_net_dev(cd)))

		/*

net/bridge/br_sysfs_if.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -17,6 +17,10 @@

		#include "br_private.h"

		/* IMPORTANT: new bridge port options must be added with netlink support only
		* please do not add new sysfs entries
		*/

		struct brport_attribute {
		struct attribute attr;
		ssize_t (show)(struct net_bridge_port , char *);