Unverified Commit 1de65309 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!15096 net: inet: do not leave a dangling sk pointer in inet_create() 

Merge Pull Request from: @ci-robot 
 
PR sync from: Dong Chenchen <dongchenchen2@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/32V7QJT7X6X7G2LQUTFDBTTMXQWYPZJI/ 
 
https://gitee.com/src-openeuler/kernel/issues/IBEAPL 
 
Link:https://gitee.com/openeuler/kernel/pulls/15096

 

Reviewed-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: default avatarLi Nan <linan122@huawei.com>
Signed-off-by: default avatarLi Nan <linan122@huawei.com>
parents a90a44c2 25a466eb

net/ipv4/af_inet.c

+10 −12
Original line number Diff line number Diff line
@@ -373,32 +373,30 @@ static int inet_create(struct net *net, struct socket *sock, int protocol, 
		inet->inet_sport = htons(inet->inet_num);

		/* Add to protocol hash chains. */

		err = sk->sk_prot->hash(sk);

		if (err) {

			sk_common_release(sk);

			goto out;

		}

		if (err)

			goto out_sk_release;

	}



	if (sk->sk_prot->init) {

		err = sk->sk_prot->init(sk);

		if (err) {

			sk_common_release(sk);

			goto out;

		}

		if (err)

			goto out_sk_release;

	}



	if (!kern) {

		err = BPF_CGROUP_RUN_PROG_INET_SOCK(sk);

		if (err) {

			sk_common_release(sk);

			goto out;

		}

		if (err)

			goto out_sk_release;

	}

out:

	return err;

out_rcu_unlock:

	rcu_read_unlock();

	goto out;

out_sk_release:

	sk_common_release(sk);

	sock->sk = NULL;

	goto out;

}