Commit 1dde47a6 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net: mdiobus: get rid of a BUG_ON() 



We spotted a bug recently during a review where a driver was
unregistering a bus that wasn't registered, which would trigger this
BUG_ON().  Let's handle that situation more gracefully, and just print
a warning and return.

Reported-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 37781fd2

drivers/net/phy/mdio_bus.c

+2 −1
Original line number Diff line number Diff line
@@ -607,7 +607,8 @@ void mdiobus_unregister(struct mii_bus *bus) 
	struct mdio_device *mdiodev;

	int i;



	BUG_ON(bus->state != MDIOBUS_REGISTERED);

	if (WARN_ON_ONCE(bus->state != MDIOBUS_REGISTERED))

		return;

	bus->state = MDIOBUS_UNREGISTERED;



	for (i = 0; i < PHY_MAX_ADDR; i++) {