Commit 1dbe61bf authored by Luo Jiaxing's avatar Luo Jiaxing Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: Enable debugfs support by default 

Add a config option to enable debugfs support by default. And if debugfs
support is enabled by default, dump count default value is increased to 50
as generally users want something bigger than the current default in that
situation.

Link: https://lore.kernel.org/r/1611659068-131975-4-git-send-email-john.garry@huawei.com


Signed-off-by: default avatarLuo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 69bfa5fd

drivers/scsi/hisi_sas/Kconfig

+6 −0
Original line number Diff line number Diff line
@@ -18,3 +18,9 @@ config SCSI_HISI_SAS_PCI 
	depends on ACPI

	help

		This driver supports HiSilicon's SAS HBA based on PCI device



config SCSI_HISI_SAS_DEBUGFS_DEFAULT_ENABLE

	bool "HiSilicon SAS debugging default enable"

	depends on SCSI_HISI_SAS

	help

		Set Y to default enable DEBUGFS for SCSI_HISI_SAS

drivers/scsi/hisi_sas/hisi_sas_main.c

+11 −2
Original line number Diff line number Diff line
@@ -2722,12 +2722,21 @@ int hisi_sas_remove(struct platform_device *pdev) 
}

EXPORT_SYMBOL_GPL(hisi_sas_remove);



#if IS_ENABLED(CONFIG_SCSI_HISI_SAS_DEBUGFS_DEFAULT_ENABLE)

#define DEBUGFS_ENABLE_DEFAULT  "enabled"

bool hisi_sas_debugfs_enable = true;

u32 hisi_sas_debugfs_dump_count = 50;

#else

#define DEBUGFS_ENABLE_DEFAULT "disabled"

bool hisi_sas_debugfs_enable;

u32 hisi_sas_debugfs_dump_count = 1;

#endif



EXPORT_SYMBOL_GPL(hisi_sas_debugfs_enable);

module_param_named(debugfs_enable, hisi_sas_debugfs_enable, bool, 0444);

MODULE_PARM_DESC(hisi_sas_debugfs_enable, "Enable driver debugfs (default disabled)");

MODULE_PARM_DESC(hisi_sas_debugfs_enable,

		 "Enable driver debugfs (default "DEBUGFS_ENABLE_DEFAULT")");



u32 hisi_sas_debugfs_dump_count = 1;

EXPORT_SYMBOL_GPL(hisi_sas_debugfs_dump_count);

module_param_named(debugfs_dump_count, hisi_sas_debugfs_dump_count, uint, 0444);

MODULE_PARM_DESC(hisi_sas_debugfs_dump_count, "Number of debugfs dumps to allow");