Commit 1db06050 authored by Guido Günther's avatar Guido Günther
Browse files

drm: mxsfb: Set fallback bus format when the bridge doesn't provide one 



If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is
returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in
that case.

This unbreaks e.g. using mxsfb with the nwl bridge and mipi dsi panels.

Reported-by: default avatarMartin Kepplinger <martink@posteo.de>
Signed-off-by: default avatarGuido Günther <agx@sigxcpu.org>
Reviewed-by: default avatarLucas Stach <l.stach@pengutronix.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarStefan Agner <stefan@agner.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/781f0352052cc50c823c199ef5f53c84902d0580.1633959458.git.agx@sigxcpu.org
parent e2e0ee7e

drivers/gpu/drm/mxsfb/mxsfb_kms.c

+6 −0
Original line number Diff line number Diff line
@@ -362,6 +362,12 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc, 
			drm_atomic_get_new_bridge_state(state,

							mxsfb->bridge);

		bus_format = bridge_state->input_bus_cfg.format;

		if (bus_format == MEDIA_BUS_FMT_FIXED) {

			dev_warn_once(drm->dev,

				      "Bridge does not provide bus format, assuming MEDIA_BUS_FMT_RGB888_1X24.\n"

				      "Please fix bridge driver by handling atomic_get_input_bus_fmts.\n");

			bus_format = MEDIA_BUS_FMT_RGB888_1X24;

		}

	}



	/* If there is no bridge, use bus format from connector */