Commit 1d7ff300 authored by Finn Thain's avatar Finn Thain Committed by felix
Browse files

macintosh/via-macii: Fix "BUG: sleeping function called from invalid context" 

stable inclusion
from stable-v5.10.219
commit 280619bbdeac186fb320fab3d61122d2a085def8
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IA6SHU
CVE: CVE-2024-38607

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=280619bbdeac186fb320fab3d61122d2a085def8



--------------------------------

[ Upstream commit d301a71c76ee4c384b4e03cdc320a55f5cf1df05 ]

The via-macii ADB driver calls request_irq() after disabling hard
interrupts. But disabling interrupts isn't necessary here because the
VIA shift register interrupt was masked during VIA1 initialization.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarFinn Thain <fthain@linux-m68k.org>
Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/419fcc09d0e563b425c419053d02236b044d86b0.1710298421.git.fthain@linux-m68k.org


Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarFelix Fu <fuzhen5@huawei.com>
parent 01815e5c

drivers/macintosh/via-macii.c

+3 −8
Original line number Diff line number Diff line
@@ -142,24 +142,19 @@ static int macii_probe(void) 
/* Initialize the driver */

static int macii_init(void)

{

	unsigned long flags;

	int err;



	local_irq_save(flags);



	err = macii_init_via();

	if (err)

		goto out;

		return err;



	err = request_irq(IRQ_MAC_ADB, macii_interrupt, 0, "ADB",

			  macii_interrupt);

	if (err)

		goto out;

		return err;



	macii_state = idle;

out:

	local_irq_restore(flags);

	return err;

	return 0;

}



/* initialize the hardware */