Commit 1d489151 authored by Josh Poimboeuf's avatar Josh Poimboeuf
Browse files

objtool: Don't fail on missing symbol table 



Thanks to a recent binutils change which doesn't generate unused
symbols, it's now possible for thunk_64.o be completely empty without
CONFIG_PREEMPTION: no text, no data, no symbols.

We could edit the Makefile to only build that file when
CONFIG_PREEMPTION is enabled, but that will likely create confusion
if/when the thunks end up getting used by some other code again.

Just ignore it and move on.

Reported-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Tested-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1254


Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
parent 655cf865

tools/objtool/elf.c

+5 −2
Original line number Diff line number Diff line
@@ -380,8 +380,11 @@ static int read_symbols(struct elf *elf) 


	symtab = find_section_by_name(elf, ".symtab");

	if (!symtab) {

		WARN("missing symbol table");

		return -1;

		/*

		 * A missing symbol table is actually possible if it's an empty

		 * .o file.  This can happen for thunk_64.o.

		 */

		return 0;

	}



	symtab_shndx = find_section_by_name(elf, ".symtab_shndx");