Commit 1d3a3f3b authored Dec 23, 2020 by Tom Rix Committed by Saeed Mahameed Feb 01, 2021

net/mlx5e: remove h from printk format specifier



This change fixes the checkpatch warning described in this commit
commit cbacb5ab ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")

Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xudi] or %h[xudi].

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

parent 1dd55ba2

drivers/net/ethernet/mellanox/mlx5/core/en/params.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -179,7 +179,7 @@ int mlx5e_validate_params(struct mlx5e_priv priv, struct mlx5e_params params)

		stop_room = mlx5e_calc_sq_stop_room(priv->mdev, params);
		if (stop_room >= sq_size) {
		netdev_err(priv->netdev, "Stop room %hu is bigger than the SQ size %zu\n",
		netdev_err(priv->netdev, "Stop room %u is bigger than the SQ size %zu\n",
		stop_room, sq_size);
		return -EINVAL;
		}

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3888,7 +3888,7 @@ static int set_feature_lro(struct net_device *netdev, bool enable)
		mutex_lock(&priv->state_lock);

		if (enable && priv->xsk.refcnt) {
		netdev_warn(netdev, "LRO is incompatible with AF_XDP (%hu XSKs are active)\n",
		netdev_warn(netdev, "LRO is incompatible with AF_XDP (%u XSKs are active)\n",
		priv->xsk.refcnt);
		err = -EINVAL;
		goto out;
		@@ -4139,7 +4139,7 @@ static bool mlx5e_xsk_validate_mtu(struct net_device *netdev,
		max_mtu_page = mlx5e_xdp_max_mtu(new_params, &xsk);
		max_mtu = min(max_mtu_frame, max_mtu_page);

		netdev_err(netdev, "MTU %d is too big for an XSK running on channel %hu. Try MTU <= %d\n",
		netdev_err(netdev, "MTU %d is too big for an XSK running on channel %u. Try MTU <= %d\n",
		new_params->sw_mtu, ix, max_mtu);
		return false;
		}