Commit 1d1fb961 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Michael Ellerman
Browse files

powerpc/xive: Fix refcount leak in xive_spapr_init 



of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: eac1e731 ("powerpc/xive: guest exploitation of the XIVE interrupt controller")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarCédric Le Goater <clg@kaod.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220512090535.33397-1-linmq006@gmail.com
parent 48b63961

arch/powerpc/sysdev/xive/spapr.c

+5 −2
Original line number Diff line number Diff line
@@ -832,12 +832,12 @@ bool __init xive_spapr_init(void) 
	/* Resource 1 is the OS ring TIMA */

	if (of_address_to_resource(np, 1, &r)) {

		pr_err("Failed to get thread mgmnt area resource\n");

		return false;

		goto err_put;

	}

	tima = ioremap(r.start, resource_size(&r));

	if (!tima) {

		pr_err("Failed to map thread mgmnt area\n");

		return false;

		goto err_put;

	}



	if (!xive_get_max_prio(&max_prio))
@@ -873,6 +873,7 @@ bool __init xive_spapr_init(void) 
	if (!xive_core_init(np, &xive_spapr_ops, tima, TM_QW1_OS, max_prio))

		goto err_mem_free;



	of_node_put(np);

	pr_info("Using %dkB queues\n", 1 << (xive_queue_shift - 10));

	return true;
@@ -880,6 +881,8 @@ bool __init xive_spapr_init(void) 
	xive_irq_bitmap_remove_all();

err_unmap:

	iounmap(tima);

err_put:

	of_node_put(np);

	return false;

}