Commit 1d09697f authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Michael Ellerman
Browse files

cxl: Fix refcount leak in cxl_calc_capp_routing 



of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
This function only calls of_node_put() in normal path,
missing it in the error path.
Add missing of_node_put() to avoid refcount leak.

Fixes: f24be42a ("cxl: Add psl9 specific code")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Acked-by: default avatarAndrew Donnellan <ajd@linux.ibm.com>
Acked-by: default avatarFrederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605060038.62217-1-linmq006@gmail.com
parent 37195ede

drivers/misc/cxl/pci.c

+1 −0
Original line number Diff line number Diff line
@@ -387,6 +387,7 @@ int cxl_calc_capp_routing(struct pci_dev *dev, u64 *chipid, 
	rc = get_phb_index(np, phb_index);

	if (rc) {

		pr_err("cxl: invalid phb index\n");

		of_node_put(np);

		return rc;

	}