Unverified Commit 1cf2aa66 authored by Hans de Goede's avatar Hans de Goede Committed by Mark Brown
Browse files

ASoC: es8316: Use IRQF_NO_AUTOEN when requesting the IRQ 



Use the new IRQF_NO_AUTOEN flag when requesting the IRQ, rather then
disabling it immediately after requesting it.

This fixes a possible race where the IRQ might trigger between requesting
and disabling it; and this also leads to a small code cleanup.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211003132255.31743-1-hdegoede@redhat.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent aab1ad11

sound/soc/codecs/es8316.c

+2 −5
Original line number Diff line number Diff line
@@ -811,12 +811,9 @@ static int es8316_i2c_probe(struct i2c_client *i2c_client, 
	mutex_init(&es8316->lock);



	ret = devm_request_threaded_irq(dev, es8316->irq, NULL, es8316_irq,

					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,

					IRQF_TRIGGER_HIGH | IRQF_ONESHOT | IRQF_NO_AUTOEN,

					"es8316", es8316);

	if (ret == 0) {

		/* Gets re-enabled by es8316_set_jack() */

		disable_irq(es8316->irq);

	} else {

	if (ret) {

		dev_warn(dev, "Failed to get IRQ %d: %d\n", es8316->irq, ret);

		es8316->irq = -ENXIO;

	}