Commit 1cb3dc3f authored by Naohiro Aota's avatar Naohiro Aota Committed by David Sterba
Browse files

btrfs: zoned: disallow fitrim on zoned filesystems 



The implementation of fitrim depends on space cache, which is not used
and disabled for zoned extent allocator. So the current code does not
work with zoned filesystem.

In the future, we can implement fitrim for zoned filesystems by enabling
space cache (but, only for fitrim) or scanning the extent tree at fitrim
time.  For now, disallow fitrim on zoned filesystems.

Reviewed-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarNaohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent b53429ba

fs/btrfs/ioctl.c

+8 −0
Original line number Diff line number Diff line
@@ -527,6 +527,14 @@ static noinline int btrfs_ioctl_fitrim(struct btrfs_fs_info *fs_info, 
	if (!capable(CAP_SYS_ADMIN))

		return -EPERM;



	/*

	 * btrfs_trim_block_group() depends on space cache, which is not

	 * available in zoned filesystem. So, disallow fitrim on a zoned

	 * filesystem for now.

	 */

	if (btrfs_is_zoned(fs_info))

		return -EOPNOTSUPP;



	/*

	 * If the fs is mounted with nologreplay, which requires it to be

	 * mounted in RO mode as well, we can not allow discard on free space