Unverified Commit 1c668e1c authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: qcom: sdm845: Fix array out of bounds access 



Static analysis Coverity had detected a potential array out-of-bounds
write issue due to the fact that MAX AFE port Id was set to 16 instead
of using AFE_PORT_MAX macro.

Fix this by properly using AFE_PORT_MAX macro.

Fixes: 1b93a884 ("ASoC: qcom: sdm845: handle soundwire stream")
Reported-by: default avatarJohn Stultz <john.stultz@linaro.org>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210309142129.14182-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7c2a783c

sound/soc/qcom/sdm845.c

+2 −2
Original line number Diff line number Diff line
@@ -33,12 +33,12 @@ 
struct sdm845_snd_data {

	struct snd_soc_jack jack;

	bool jack_setup;

	bool stream_prepared[SLIM_MAX_RX_PORTS];

	bool stream_prepared[AFE_PORT_MAX];

	struct snd_soc_card *card;

	uint32_t pri_mi2s_clk_count;

	uint32_t sec_mi2s_clk_count;

	uint32_t quat_tdm_clk_count;

	struct sdw_stream_runtime *sruntime[SLIM_MAX_RX_PORTS];

	struct sdw_stream_runtime *sruntime[AFE_PORT_MAX];

};



static unsigned int tdm_slot_offset[8] = {0, 4, 8, 12, 16, 20, 24, 28};