Commit 1c4de499 authored by Stafford Horne's avatar Stafford Horne
Browse files

openrisc: Add missing prototypes for assembly called fnctions 



These functions are all called from assembly files so there is no need
for a prototype in a header file, but when compiling with W=1 enabling
-Wmissing-prototypes the compiler warns:

arch/openrisc/kernel/ptrace.c:191:17: error: no previous prototype for 'do_syscall_trace_enter' [-Werror=missing-prototypes]
arch/openrisc/kernel/ptrace.c:210:17: error: no previous prototype for 'do_syscall_trace_leave' [-Werror=missing-prototypes]
arch/openrisc/kernel/signal.c:293:1: error: no previous prototype for 'do_work_pending' [-Werror=missing-prototypes]
arch/openrisc/kernel/signal.c:68:17: error: no previous prototype for '_sys_rt_sigreturn' [-Werror=missing-prototypes]
arch/openrisc/kernel/time.c:111:25: error: no previous prototype for 'timer_interrupt' [-Werror=missing-prototypes]
arch/openrisc/kernel/traps.c:239:17: error: no previous prototype for 'unhandled_exception' [-Werror=missing-prototypes]
arch/openrisc/kernel/traps.c:246:17: error: no previous prototype for 'do_fpe_trap' [-Werror=missing-prototypes]
arch/openrisc/kernel/traps.c:268:17: error: no previous prototype for 'do_trap' [-Werror=missing-prototypes]
arch/openrisc/kernel/traps.c:273:17: error: no previous prototype for 'do_unaligned_access' [-Werror=missing-prototypes]
arch/openrisc/kernel/traps.c:286:17: error: no previous prototype for 'do_bus_fault' [-Werror=missing-prototypes]
arch/openrisc/kernel/traps.c:462:17: error: no previous prototype for 'do_illegal_instruction' [-Werror=missing-prototypes]
arch/openrisc/mm/fault.c:44:17: error: no previous prototype for 'do_page_fault' [-Werror=missing-prototypes]

Since these are not needed in header files, fix these by adding
prototypes to the top of the respective C files.

Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
Closes: https://lore.kernel.org/linux-kernel/20230810141947.1236730-17-arnd@kernel.org/


Signed-off-by: default avatarStafford Horne <shorne@gmail.com>
parent 232ba163

arch/openrisc/kernel/ptrace.c

+4 −0
Original line number Diff line number Diff line
@@ -27,6 +27,10 @@ 
#include <asm/thread_info.h>

#include <asm/page.h>



asmlinkage long do_syscall_trace_enter(struct pt_regs *regs);



asmlinkage void do_syscall_trace_leave(struct pt_regs *regs);



/*

 * Copy the thread state to a regset that can be interpreted by userspace.

 *

arch/openrisc/kernel/signal.c

+5 −0
Original line number Diff line number Diff line
@@ -34,6 +34,11 @@ struct rt_sigframe { 
	unsigned char retcode[16];	/* trampoline code */

};



asmlinkage long _sys_rt_sigreturn(struct pt_regs *regs);



asmlinkage int do_work_pending(struct pt_regs *regs, unsigned int thread_flags,

			       int syscall);



static int restore_sigcontext(struct pt_regs *regs,

			      struct sigcontext __user *sc)

{

arch/openrisc/kernel/smp.c

+2 −0
Original line number Diff line number Diff line
@@ -23,6 +23,8 @@ 
#include <asm/cacheflush.h>

#include <asm/time.h>



asmlinkage __init void secondary_start_kernel(void);



static void (*smp_cross_call)(const struct cpumask *, unsigned int);



unsigned long secondary_release = -1;

arch/openrisc/kernel/time.c

+2 −0
Original line number Diff line number Diff line
@@ -25,6 +25,8 @@ 
#include <asm/cpuinfo.h>

#include <asm/time.h>



irqreturn_t __irq_entry timer_interrupt(struct pt_regs *regs);



/* Test the timer ticks to count, used in sync routine */

inline void openrisc_timer_set(unsigned long count)

{

arch/openrisc/kernel/traps.c

+8 −0
Original line number Diff line number Diff line
@@ -38,6 +38,14 @@ static int kstack_depth_to_print = 0x180; 
int lwa_flag;

static unsigned long __user *lwa_addr;



asmlinkage void unhandled_exception(struct pt_regs *regs, int ea, int vector);

asmlinkage void do_trap(struct pt_regs *regs, unsigned long address);

asmlinkage void do_fpe_trap(struct pt_regs *regs, unsigned long address);

asmlinkage void do_unaligned_access(struct pt_regs *regs, unsigned long address);

asmlinkage void do_bus_fault(struct pt_regs *regs, unsigned long address);

asmlinkage void do_illegal_instruction(struct pt_regs *regs,

				       unsigned long address);



static void print_trace(void *data, unsigned long addr, int reliable)

{

	const char *loglvl = data;