Commit 1c442d22 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: handle record_root_in_trans failure in qgroup_account_snapshot 



record_root_in_trans can fail currently, so handle this failure
properly.

Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 68075ea8

fs/btrfs/transaction.c

+4 −2
Original line number Diff line number Diff line
@@ -1454,7 +1454,9 @@ static int qgroup_account_snapshot(struct btrfs_trans_handle *trans, 
	 * recorded root will never be updated again, causing an outdated root

	 * item.

	 */

	record_root_in_trans(trans, src, 1);

	ret = record_root_in_trans(trans, src, 1);

	if (ret)

		return ret;



	/*

	 * btrfs_qgroup_inherit relies on a consistent view of the usage for the
@@ -1523,7 +1525,7 @@ static int qgroup_account_snapshot(struct btrfs_trans_handle *trans, 
	 * insert_dir_item()

	 */

	if (!ret)

		record_root_in_trans(trans, parent, 1);

		ret = record_root_in_trans(trans, parent, 1);

	return ret;

}