Commit 1c3ef4c5 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/malidp: Don't call drm_crtc_vblank_off on unbind 



This is already done as part of the drm_atomic_helper_shutdown(),
and in that case only for the crtc which are actually on.

v2: I overlooked that malidp also needs to have it's interrupt shut
down reordered.

Acked-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200602095505.37509-1-daniel.vetter@ffwll.ch
parent 26d3ac3c

drivers/gpu/drm/arm/malidp_drv.c

+1 −2
Original line number Diff line number Diff line
@@ -929,11 +929,10 @@ static void malidp_unbind(struct device *dev) 
	drm_dev_unregister(drm);

	drm_kms_helper_poll_fini(drm);

	pm_runtime_get_sync(dev);

	drm_crtc_vblank_off(&malidp->crtc);

	drm_atomic_helper_shutdown(drm);

	malidp_se_irq_fini(hwdev);

	malidp_de_irq_fini(hwdev);

	drm->irq_enabled = false;

	drm_atomic_helper_shutdown(drm);

	component_unbind_all(dev, drm);

	of_node_put(malidp->crtc.port);

	malidp->crtc.port = NULL;