Commit 1c360cc1 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

gve: Fix off by one in gve_tx_timeout() 



The priv->ntfy_blocks[] has "priv->num_ntfy_blks" elements so this >
needs to be >= to prevent an off by one bug.  The priv->ntfy_blocks[]
array is allocated in gve_alloc_notify_blocks().

Fixes: 87a7f321 ("gve: Recover from queue stall due to missed IRQ")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0b911192

drivers/net/ethernet/google/gve/gve_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1137,7 +1137,7 @@ static void gve_tx_timeout(struct net_device *dev, unsigned int txqueue) 
		goto reset;



	ntfy_idx = gve_tx_idx_to_ntfy(priv, txqueue);

	if (ntfy_idx > priv->num_ntfy_blks)

	if (ntfy_idx >= priv->num_ntfy_blks)

		goto reset;



	block = &priv->ntfy_blocks[ntfy_idx];