Commit 1bfa4d0c authored by Bailey Forrest's avatar Bailey Forrest Committed by David S. Miller
Browse files

gve: DQO: Remove incorrect prefetch 



The prefetch is incorrectly using the dma address instead of the virtual
address.

It's supposed to be:
prefetch((char *)buf_state->page_info.page_address +
	 buf_state->page_info.page_offset)

However, after correcting this mistake, there is no evidence of
performance improvement.

Fixes: 9b8dd5e5 ("gve: DQO: Add RX path")
Signed-off-by: default avatarBailey Forrest <bcf@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40fc3054

drivers/net/ethernet/google/gve/gve_rx_dqo.c

+0 −7
Original line number Diff line number Diff line
@@ -566,13 +566,6 @@ static int gve_rx_dqo(struct napi_struct *napi, struct gve_rx_ring *rx, 
		return 0;

	}



	/* Prefetch the payload header. */

	prefetch((char *)buf_state->addr + buf_state->page_info.page_offset);

#if L1_CACHE_BYTES < 128

	prefetch((char *)buf_state->addr + buf_state->page_info.page_offset +

		 L1_CACHE_BYTES);

#endif



	if (eop && buf_len <= priv->rx_copybreak) {

		rx->skb_head = gve_rx_copy(priv->dev, napi,

					   &buf_state->page_info, buf_len, 0);