Commit 1bf7a749 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

ps3vram: remove bio splitting 



ps3vram iterates over the bio one segment, that is page aligned and max
page sized chunk, a time.  Because of that there is no point in
calling bio_split_to_limits, or explicitly setting the default limits
that are only used by bio_split_to_limits.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Tested-by: default avatarGeoff Levand <geoff@infradead.org>
Link: https://lore.kernel.org/r/20230123074718.57951-1-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 33391eec

drivers/block/ps3vram.c

+0 −7
Original line number Diff line number Diff line
@@ -586,10 +586,6 @@ static void ps3vram_submit_bio(struct bio *bio) 


	dev_dbg(&dev->core, "%s\n", __func__);



	bio = bio_split_to_limits(bio);

	if (!bio)

		return;



	spin_lock_irq(&priv->lock);

	busy = !bio_list_empty(&priv->list);

	bio_list_add(&priv->list, bio);
@@ -749,9 +745,6 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev) 
	gendisk->private_data = dev;

	strscpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name));

	set_capacity(gendisk, priv->size >> 9);

	blk_queue_max_segments(gendisk->queue, BLK_MAX_SEGMENTS);

	blk_queue_max_segment_size(gendisk->queue, BLK_MAX_SEGMENT_SIZE);

	blk_queue_max_hw_sectors(gendisk->queue, BLK_SAFE_MAX_SECTORS);



	dev_info(&dev->core, "%s: Using %llu MiB of GPU memory\n",

		 gendisk->disk_name, get_capacity(gendisk) >> 11);