Commit 1be2143f authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: pcm: Make mmap status read-only 



The mmap status record should be read-only.  Modifying it from
user-space may screw up things unexpectedly, so let's clear the write
bits at exposing it.

Note that alsa-lib and other known user-space apps access the mmapped
status only as read-only, hence this change shouldn't break the
existing applications.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Link: https://lore.kernel.org/r/20220926135558.26580-3-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f0061c18

sound/core/pcm_native.c

+1 −0
Original line number Diff line number Diff line
@@ -3668,6 +3668,7 @@ static int snd_pcm_mmap_status(struct snd_pcm_substream *substream, struct file 
	area->vm_ops = &snd_pcm_vm_ops_status;

	area->vm_private_data = substream;

	area->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;

	area->vm_flags &= ~(VM_WRITE | VM_MAYWRITE);

	return 0;

}