Commit 1bcebcab authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal: intel: int340x: Improve int340x_thermal_set_trip_temp() 



Instead of using snprintf() to populate the ACPI object name in
int340x_thermal_set_trip_temp(), use an appropriate initializer
and make the function fail if its trip argument is greater than 9,
because ACPI object names can only be 4 characters long and it does
not make sense to even try to evaluate objects with longer names (that
argument is guaranteed to be non-negative, because it comes from the
thermal code that will not pass negative trip numbers to zone
callbacks).

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Tested-by: default avatarZhang Rui <rui.zhang@intel.com>
Reviewed-by: default avatarZhang Rui <rui.zhang@intel.com>
parent d0009d14

drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c

+4 −2
Original line number Diff line number Diff line
@@ -42,10 +42,12 @@ static int int340x_thermal_set_trip_temp(struct thermal_zone_device *zone, 
					 int trip, int temp)

{

	struct int34x_thermal_zone *d = zone->devdata;

	char name[] = {'P', 'A', 'T', '0' + trip, '\0'};

	acpi_status status;

	char name[10];



	snprintf(name, sizeof(name), "PAT%d", trip);

	if (trip > 9)

		return -EINVAL;



	status = acpi_execute_simple_method(d->adev->handle, name,

					    millicelsius_to_deci_kelvin(temp));

	if (ACPI_FAILURE(status))