Commit 1bc6ea31 authored May 25, 2021 by Uwe Kleine-König Committed by Thierry Reding Jun 28, 2021

pwm: imx1: Don't disable clocks at device remove time



The .remove() callback disables clocks that were not enabled in
.probe(). So just probing and then unbinding the driver results in a clk
enable imbalance.

So just drop the call to disable the clocks. (Which BTW was also in the
wrong order because the call makes the PWM unfunctional and so should
have come only after pwmchip_remove()).

Fixes: 9f4c8f96 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 9c6a02e6

drivers/pwm/pwm-imx1.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -168,8 +168,6 @@ static int pwm_imx1_remove(struct platform_device *pdev)
		{
		struct pwm_imx1_chip *imx = platform_get_drvdata(pdev);

		pwm_imx1_clk_disable_unprepare(&imx->chip);

		return pwmchip_remove(&imx->chip);
		}