Commit 1b9b7a6f authored by Dan Williams's avatar Dan Williams
Browse files

cxl/region: Validate region mode vs decoder mode 



In preparation for a new region mode, do not, for example, allow
'ram' decoders to be assigned to 'pmem' regions and vice versa.

Reviewed-by: default avatarVishal Verma <vishal.l.verma@intel.com>
Reviewed-by: default avatarGregory Price <gregory.price@memverge.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Tested-by: default avatarFan Ni <fan.ni@samsung.com>
Link: https://lore.kernel.org/r/167601995111.1924368.7459128614177994602.stgit@dwillia2-xfh.jf.intel.com


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent a8e7d558

drivers/cxl/core/region.c

+6 −0
Original line number Diff line number Diff line
@@ -1221,6 +1221,12 @@ static int cxl_region_attach(struct cxl_region *cxlr, 
	struct cxl_dport *dport;

	int i, rc = -ENXIO;



	if (cxled->mode != cxlr->mode) {

		dev_dbg(&cxlr->dev, "%s region mode: %d mismatch: %d\n",

			dev_name(&cxled->cxld.dev), cxlr->mode, cxled->mode);

		return -EINVAL;

	}



	if (cxled->mode == CXL_DECODER_DEAD) {

		dev_dbg(&cxlr->dev, "%s dead\n", dev_name(&cxled->cxld.dev));

		return -ENODEV;