Commit 1b9728a0 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva
Browse files

drm/amd/display: Fix Wstringop-overflow warnings in dc_link_dp.c 

Fix the following Wstringop-overflow warnings when building with GCC-11:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:388:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:388:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:388:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1491:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2613:25: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2613:25: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]

by removing the over-specified array size from the argument declarations.

This helps with the ongoing efforts to globally enable
-Wstringop-overflow.

Link: https://github.com/KSPP/linux/issues/181


Acked-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
parent 54db804d

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

+2 −2
Original line number Diff line number Diff line
@@ -793,7 +793,7 @@ bool dp_is_interlane_aligned(union lane_align_status_updated align_status) 
void dp_hw_to_dpcd_lane_settings(

		const struct link_training_settings *lt_settings,

		const struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],

		union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX])

		union dpcd_training_lane dpcd_lane_settings[])

{

	uint8_t lane = 0;
@@ -823,7 +823,7 @@ void dp_decide_lane_settings( 
		const struct link_training_settings *lt_settings,

		const union lane_adjust ln_adjust[LANE_COUNT_DP_MAX],

		struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],

		union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX])

		union dpcd_training_lane dpcd_lane_settings[])

{

	uint32_t lane;

drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h

+2 −2
Original line number Diff line number Diff line
@@ -148,12 +148,12 @@ bool dp_is_max_vs_reached( 
void dp_hw_to_dpcd_lane_settings(

	const struct link_training_settings *lt_settings,

	const struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],

	union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX]);

	union dpcd_training_lane dpcd_lane_settings[]);

void dp_decide_lane_settings(

	const struct link_training_settings *lt_settings,

	const union lane_adjust ln_adjust[LANE_COUNT_DP_MAX],

	struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],

	union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX]);

	union dpcd_training_lane dpcd_lane_settings[]);



uint32_t dp_translate_training_aux_read_interval(uint32_t dpcd_aux_read_interval);