Commit 1b88b47e authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

wifi: mt76: dma: free rx_head in mt76_dma_rx_cleanup 



Free rx_head skb in mt76_dma_rx_cleanup routine in order to avoid
possible memory leak at module unload.

Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent da5b4d93

drivers/net/wireless/mediatek/mt76/dma.c

+7 −6
Original line number Diff line number Diff line
@@ -721,6 +721,7 @@ mt76_dma_rx_cleanup(struct mt76_dev *dev, struct mt76_queue *q) 
		return;



	spin_lock_bh(&q->lock);



	do {

		buf = mt76_dma_dequeue(dev, q, true, NULL, NULL, &more, NULL);

		if (!buf)
@@ -728,6 +729,12 @@ mt76_dma_rx_cleanup(struct mt76_dev *dev, struct mt76_queue *q) 


		skb_free_frag(buf);

	} while (1);



	if (q->rx_head) {

		dev_kfree_skb(q->rx_head);

		q->rx_head = NULL;

	}



	spin_unlock_bh(&q->lock);



	if (!q->rx_page.va)
@@ -753,12 +760,6 @@ mt76_dma_rx_reset(struct mt76_dev *dev, enum mt76_rxq_id qid) 
	mt76_dma_rx_cleanup(dev, q);

	mt76_dma_sync_idx(dev, q);

	mt76_dma_rx_fill(dev, q);



	if (!q->rx_head)

		return;



	dev_kfree_skb(q->rx_head);

	q->rx_head = NULL;

}



static void