Commit 1b6a1a16 authored by Stephan Gerhold's avatar Stephan Gerhold Committed by Bjorn Andersson
Browse files

arm64: dts: qcom: msm8916: Replace invalid bias-pull-none property 



msm8916-pins.dtsi specifies "bias-pull-none" for most of the audio
pin configurations. This was likely copied from the qcom kernel fork
where the same property was used for these audio pins.

However, "bias-pull-none" actually does not exist at all - not in
mainline and not in downstream. I can only guess that the original
intention was to configure "no pull", i.e. bias-disable.

Change it to that instead.

Fixes: 143bb9ad ("arm64: dts: qcom: add audio pinctrls")
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarStephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200605185916.318494-2-stephan@gerhold.net


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent c00b5c28

arch/arm64/boot/dts/qcom/msm8916-pins.dtsi

+5 −5
Original line number Diff line number Diff line
@@ -556,7 +556,7 @@ 
				pins = "gpio63", "gpio64", "gpio65", "gpio66",

				       "gpio67", "gpio68";

				drive-strength = <8>;

				bias-pull-none;

				bias-disable;

			};

		};

		cdc_pdm_lines_sus: pdm-lines-off {
@@ -585,7 +585,7 @@ 
				pins = "gpio113", "gpio114", "gpio115",

				       "gpio116";

				drive-strength = <8>;

				bias-pull-none;

				bias-disable;

			};

		};
@@ -613,7 +613,7 @@ 
			pinconf {

				pins = "gpio110";

				drive-strength = <8>;

				bias-pull-none;

				bias-disable;

			};

		};
@@ -639,7 +639,7 @@ 
			pinconf {

				pins = "gpio116";

				drive-strength = <8>;

				bias-pull-none;

				bias-disable;

			};

		};

		ext_mclk_tlmm_lines_sus: mclk-lines-off {
@@ -667,7 +667,7 @@ 
				pins = "gpio112", "gpio117", "gpio118",

					"gpio119";

				drive-strength = <8>;

				bias-pull-none;

				bias-disable;

			};

		};

		ext_sec_tlmm_lines_sus: tlmm-lines-off {