Commit 1b5ab825 authored by Du Cheng's avatar Du Cheng Committed by Johannes Berg
Browse files

cfg80211: remove WARN_ON() in cfg80211_sme_connect 



A WARN_ON(wdev->conn) would trigger in cfg80211_sme_connect(), if multiple
send_msg(NL80211_CMD_CONNECT) system calls are made from the userland, which
should be anticipated and handled by the wireless driver. Remove this WARN_ON()
to prevent kernel panic if kernel is configured to "panic_on_warn".

Bug reported by syzbot.

Reported-by: default avatar <syzbot+5f9392825de654244975@syzkaller.appspotmail.com>
Signed-off-by: default avatarDu Cheng <ducheng2@gmail.com>
Link: https://lore.kernel.org/r/20210407162756.6101-1-ducheng2@gmail.com


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 7d73cd94

net/wireless/sme.c

+1 −1
Original line number Diff line number Diff line
@@ -529,7 +529,7 @@ static int cfg80211_sme_connect(struct wireless_dev *wdev, 
		cfg80211_sme_free(wdev);

	}



	if (WARN_ON(wdev->conn))

	if (wdev->conn)

		return -EINPROGRESS;



	wdev->conn = kzalloc(sizeof(*wdev->conn), GFP_KERNEL);