Commit 1b54403c authored by chongjiapeng's avatar chongjiapeng Committed by Kalle Valo
Browse files

iwlwifi: Fix missing error code in iwl_pci_probe() 



The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1376 iwl_pci_probe() warn:
missing error code 'ret'.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Fixes: 1f171f4f ("iwlwifi: Add support for getting rf id with blank otp")
Signed-off-by: default avatarchongjiapeng <jiapeng.chong@linux.alibaba.com>
Acked-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1635838727-128735-1-git-send-email-jiapeng.chong@linux.alibaba.com
parent fe785f56

drivers/net/wireless/intel/iwlwifi/pcie/drv.c

+3 −1
Original line number Diff line number Diff line
@@ -1446,8 +1446,10 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	 */

	if (iwl_trans->trans_cfg->rf_id &&

	    iwl_trans->trans_cfg->device_family >= IWL_DEVICE_FAMILY_9000 &&

	    !CSR_HW_RFID_TYPE(iwl_trans->hw_rf_id) && get_crf_id(iwl_trans))

	    !CSR_HW_RFID_TYPE(iwl_trans->hw_rf_id) && get_crf_id(iwl_trans)) {

		ret = -EINVAL;

		goto out_free_trans;

	}



	dev_info = iwl_pci_find_dev_info(pdev->device, pdev->subsystem_device,

					 CSR_HW_REV_TYPE(iwl_trans->hw_rev),